Repository navigation
fix(scripts): accept the release index digest in verify-cluster - #210
Merged
Merged
Conversation
Since releases publish a two-platform index, a correct rollout records the index digest as the pod's imageID, and the digest check compared it with the arm64 child digest and failed. The digest check is now one Python step over every running pod. A pod passes when its dmf-cms container is running and its digest is the index digest or the child digest for its node's os and architecture, with the index listing exactly one such child. A single-platform manifest passes on its digest when its config platform matches the node. The header states the one assumption the API cannot check: the runtime selects the child for the node's own platform. Closes dmfdeploy/dmfdeploy#859 Signed-off-by: znerol2 <6800371+znerol2@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/verify-cluster.shfailed on a correct 0.41.0 rollout. The release publishes a two-platform index, so the pod'simageIDis the index digest, and the script compared it with the arm64 child digest.The digest check is now one Python step that checks every running pod the deployment selects. A pod passes when:
dmf-cmscontainer is in staterunning, andDMF_CMS_IMAGE_ARCH, andThe Kubernetes API can't show which index child a runtime selected. The header states the assumption: the runtime picks the child for the node's own platform.
Verification
Live, read-only, against a sandbox running 0.41.0: digest check passes, healthz 200, exit 0. The script on main exits 1 with
DIGEST MISMATCHagainst the same cluster.skopeo inspect --raw docker://ghcr.io/dmfdeploy/dmf-cms:0.41.0 | shasum -a 256givese797da4c…, the pod's digest.Stub runs under macOS
/bin/bash3.2. Each of these fails:DMF_CMS_IMAGE_ARCH=arm64;running: null;The matching cases pass.
shellcheckandbash -npass.Review
Four rounds of adversarial review. The last one passed.
Closes dmfdeploy/dmfdeploy#859