Repository navigation
fix(console): keep the source switch panel truthful while pending - #209
Merged
Merged
Conversation
While a switch request was in flight, a topology poll that already saw the new source made the panel say the selected source was no longer available and show a different source in the picker. The panel now renders from what the operator submitted until the request settles: the picker is locked on the submitted target, the stale-target hint and the unknown-source line stay hidden, and the panel stays mounted through a failed or malformed poll. Before submit and after it settles, the checks are unchanged. Confirm buttons in ReasonConfirm also show a progress indicator and announce the pending state. Closes dmfdeploy/dmfdeploy#861 Signed-off-by: znerol2 <6800371+znerol2@users.noreply.github.com>
lkirc
approved these changes
Nov 7, 2026
lkirc
left a comment
lkirc
left a comment
There was a problem hiding this comment.
Static review of c01e546: no blocking findings. The pending-only source snapshot preserves the submitted target through topology churn and restores the existing live validation once the request settles. Required gate and all 18 checks are green.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
During a live check on 0.41.0, a source switch worked, but while it was in flight the panel said "Selected source is no longer available — choose again" and showed the wrong source in the picker. A topology poll had already seen the new source as active.
throbber-spinclass, so the reduced-motion rule stops it. A status region announces "In progress". A new optionalextraField.disabledlocks the extra field.Tests
switchSourcePending.test.tsx, 8 tests. A poll arrives while the request is pending and shows the target as active, fails, returns malformed data, or leaves no other source. Then: an error settle, a success settle, unmount and remount while pending, and the pre-submit hint.4 failed | 4 passed (8). On this branch: all pass.Review
Three rounds of adversarial review. The last one passed. Two gaps the review found already exist on main and are filed as dmfdeploy/dmfdeploy#863.
Closes dmfdeploy/dmfdeploy#861