Skip to content

fix: correct dateFormat schema type - #941

Open
Nick2bad4u wants to merge 1 commit into
dlvhdr:mainfrom
Nick2bad4u:fix/date-format-schema
Open

fix: correct dateFormat schema type#941
Nick2bad4u wants to merge 1 commit into
dlvhdr:mainfrom
Nick2bad4u:fix/date-format-schema

Conversation

@Nick2bad4u

Copy link
Copy Markdown

Summary

  • correct defaults.dateFormat from an integer to a string in the published configuration schema
  • align the schema default with the documented and runtime default, relative

Evidence

internal/config/parser.go defines DateFormat string, and the configuration documentation describes either relative or a Go time format string. The current schema mistakenly copied the integer shape/default from refetchIntervalMinutes, causing valid configurations to fail validation.

Validation

  • pnpm install --frozen-lockfile
  • pnpm build

The docs build succeeds. It reports the same three existing broken internal links unrelated to this change.

@github-actions

Copy link
Copy Markdown

👋 Hi @Nick2bad4u, thanks for the pull request! A scan flagged some concerns with it. Could you please take a look?

[pr-linked-issue] This pull request is not linked as closing any issues. This repository keeps to GitHub issues for discussing potential changes. Most or all changes should be marked as approved in an issue before a pull request is sent to resolve them. To resolve this report:

  • If this is a straightforward documentation change that doesn't need an issue, you can ignore this report
  • If there is a backing issue, add a 'fixes #...' link to the pull request body
  • If addressing a Dependabot alert, add a link to the alert (e.g., https://github.com/owner/repo/security/dependabot/123)
  • Otherwise, file an issue explaining what you'd like to happen

[pr-task-completion] This PR's body is missing [x] checks on the following tasks from the PR template.

Repositories often provide a set of tasks that pull request authors are expected to complete. Those tasks should be marked as completed with a [x] in the pull request description. Please complete those tasks and mark the checks as [x] completed.

🗺️ This message was posted automatically by OctoGuide: a bot for GitHub repository best practices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant