fix: cursor between boundaries crash - #940
Open
ltpie123 wants to merge 1 commit into
Open
Conversation
when the mentions.go does the check to see if there is a username after an "@", the cursors loc was able to get out of bounds, causing a runtime error. now userStart is able to be the same value as len(runes). fixes dlvhdr#939
This comment has been minimized.
This comment has been minimized.
ltpie123
marked this pull request as draft
July 22, 2026 22:49
ltpie123
marked this pull request as ready for review
July 22, 2026 22:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I have read the Contributing and the strict No-AI Policy guides.
Closes [BUG] Crash when comment cursor moves between boundary runes #939
When the mentions.go does the check to see if there is a username after
an "@", the cursors loc was able to get out of bounds, causing a
runtime error. Now userStart is able to be the same value as len(runes).
Testing process
Video Solution