feat: yaml config provider - #4346
Open
zilto wants to merge 2 commits into
Open
Conversation
rudolfix
reviewed
Aug 19, 2026
rudolfix
left a comment
Collaborator
There was a problem hiding this comment.
A few things before full review:
- I'd prune providers that get into initial provider list to declutter exception messages (see comments)
- I'd whitelist
yamlextensions inConfigurationFileSelectorto start sending this to runtime. enabling runtime to pass through yaml profiles is separate (right now yaml files will be pruned), but not hard - tools to redact and update config/secret files that agents are using will need to be rewritten. right now they handle toml only. also rewriting a yaml path will need some kind of convention. we'll need to maybe switch to yaml parser that preserves comments and whitespaces (we were using it in dlthub)
- there are very long module and function docstrings. those should be split and converted into comments. right now they are too sloppy. you can ask claude to apply rules from
@docstrings.mdor or try/review-vocabulary(which is based on Boeing simple simple English) and see what happens
| config_toml = ProfileConfigTomlProvider(self.settings_dir, profile_name, self.global_dir) | ||
| secrets_yaml = ProfileSecretsYamlProvider(self.settings_dir, profile_name, self.global_dir) | ||
| config_yaml = ProfileConfigYamlProvider(self.settings_dir, profile_name, self.global_dir) | ||
| warn_on_toml_yaml_collision(secrets_toml, secrets_yaml) |
Collaborator
There was a problem hiding this comment.
here I'd remove yaml providers that do not have any locations present from the list of providers below. otherwise they will be reported in configuration errors as empty providers without files. we can be smarter and also prune tomls if there are no locations defined (for both config and secrets)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #4345 (and #1596). It expands on previous work that allowed custom config provider.
Changes
There are a lot of files and lines of code changes, but it's inflated by
.yamltest cases.The main changes:
tomlconfig provider to a base classSettingsDocProvidertomlandyamlspecific classesFuture work
config.yamlandsecrets.yamldlthub.yamlfiles properly (e.g., MCP tool to read values, mentions in skills)