fix(sql_database): map Oracle TIMESTAMP WITH LOCAL TIME ZONE to timezone=true - #4343
Open
Aryan-Pardeshi wants to merge 1 commit into
Open
fix(sql_database): map Oracle TIMESTAMP WITH LOCAL TIME ZONE to timezone=true#4343Aryan-Pardeshi wants to merge 1 commit into
Aryan-Pardeshi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4315
Problem
sqla_col_to_column_schemainfers timezone-awareness fromsql_t.timezoneonly. Oracle'sTIMESTAMP WITH LOCAL TIME ZONEcolumns are reflected by SQLAlchemy withtimezone=Falsebutlocal_timezone=True, so they were mapped totimezone: falsein the dlt schema — forcing downstream timestamp normalization and breaking round-trips for LTZ data.Change
Also honor the
local_timezoneattribute (Oracle-only), viagetattrso other dialects are unaffected.Tests
test_oracle_local_time_zone_mapped_to_timezone_true—TIMESTAMP(local_timezone=True)→timezone: truetest_oracle_timestamp_plain_maps_to_timezone_false— plainTIMESTAMPstaystimezone: falseVerified:
tests/sources/sql_database/test_schema_types.py— 19 passed under SQLAlchemy 2.0.51 and 2.1.0b3.