ci: do not let SonarCloud block publishing - #18
Merged
Conversation
A rejected SONAR_TOKEN failed the scan, which skipped publish-package and blocked the 0.1.1 release.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SONAR_TOKENis being rejected (Failed to query JRE metadata), so the SonarCloud job fails.publish-packagelists it inneeds, so the job was skipped and 0.1.1 never reached PyPI.Job-level
continue-on-errormakesneeds.sonarcloud.resultreport success, so dependents run, while the job still shows a red X and the run still reports failure — a broken scan stays visible rather than silently swallowed.Tested
Workflow parses as valid YAML;
publish-packageneeds unchanged otherwise. Real verification is the next tagged build.Follow-up
The token still needs rotating. Publishing 0.1.1 also needs a tag whose commit contains this change, since tag-push runs read the workflow from the tag ref — so either cut 0.1.2 or move the 0.1.1 tag.