Skip to content

Fix dead FAQ link and broken anchors on the fundraising page#2628

Open
ericholscher wants to merge 1 commit into
django:mainfrom
ericholscher:fix-fundraising-page-links
Open

Fix dead FAQ link and broken anchors on the fundraising page#2628
ericholscher wants to merge 1 commit into
django:mainfrom
ericholscher:fix-fundraising-page-links

Conversation

@ericholscher
Copy link
Copy Markdown

The fundraising page has a "Frequently Asked Questions" link that points back to the page itself, plus two links to in-page anchors that don't exist.

The "Frequently Asked Questions" link pointed at the fundraising page
itself (there is no donations FAQ page), so it just reloaded the page.
The Benevity and "tax deductible" links pointed at #benevity-giving and
#tax-deductible anchors that do not exist on the page. Remove the dead
FAQ sentence and unwrap the two anchor links to plain text.
Copy link
Copy Markdown
Member

@adamzap adamzap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks great! I'd also like to hear from whoever owns the content of the page.

<a href="{{ fundraising_url }}#benevity-giving">Benevity Workplace Giving
Program</a> - If your employer participates, you can make donations to the
DSF via payroll deduction.
Benevity Workplace Giving Program - If your employer participates, you can
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this should point to somewhere like here?

There's also a bad link in the footer. However, this may be out of scope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants