chore(module): restructure the main pysolr module - #573
Merged
acdha merged 1 commit intoSep 8, 2026
Conversation
DhavalGojiya
force-pushed
the
chore/refactor-module-structure
branch
from
June 5, 2026 10:16
1dbdec1 to
5c53dda
Compare
Contributor
Author
|
Your review plz : @cclauss |
Contributor
|
Why not use |
DhavalGojiya
force-pushed
the
chore/refactor-module-structure
branch
from
June 22, 2026 08:36
5c53dda to
f8b84ea
Compare
Contributor
Author
Done :) spent some time learning about these methods. |
Contributor
Author
|
Your review plz: @acdha |
acdha
reviewed
Aug 7, 2026
acdha
reviewed
Aug 7, 2026
DhavalGojiya
force-pushed
the
chore/refactor-module-structure
branch
from
August 10, 2026 15:08
f8b84ea to
982ce84
Compare
acdha
reviewed
Aug 21, 2026
DhavalGojiya
force-pushed
the
chore/refactor-module-structure
branch
from
August 24, 2026 09:50
982ce84 to
cbd5436
Compare
acdha
reviewed
Aug 24, 2026
| are stripped, except for tab, newline and carriage return, which are | ||
| valid whitespace. | ||
| """ | ||
| sanitized_chars_table = str.maketrans( |
Collaborator
There was a problem hiding this comment.
This should be up at the module level so it's not run on every call.
Contributor
Author
There was a problem hiding this comment.
if we want to avoid leaking a temporary variable, the easiest way to do that would be to put it into the only place it's used:
Collaborator
There was a problem hiding this comment.
Sorry if there was any confusion, my example was at the module level combining the _CONTROL_CHARS definition and maketrans result into a single module-level declaration.
DhavalGojiya
force-pushed
the
chore/refactor-module-structure
branch
from
September 8, 2026 14:22
cbd5436 to
08e7bb5
Compare
acdha
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description