remove pywinpty py315 CI kludge - #307
Open
bckohan wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR disables (by commenting out) the custom uv index/source override that was previously used to install a Windows/Python 3.15-compatible pywinpty build, while expanding the surrounding comments explaining why that override exists.
Changes:
- Expanded the explanatory comment describing the rationale for a custom
pywinptywheel/index for Python 3.15. - Commented out the
[[tool.uv.index]]entry for the custompywinpty-py315index. - Commented out the
[tool.uv.sources]mapping that directed Windows/Python>=3.15 to that custom index.
Suppressed comments (1)
pyproject.toml:75
- With the pywinpty index commented out, this uv sources mapping is also disabled, so uv will no longer pull the Windows/Python>=3.15 build from the custom index. If the intent is to keep CI green for the existing Windows 3.15 job, this mapping needs to remain active until an upstream wheel exists.
# [tool.uv.sources]
# pywinpty = [
# { index = "pywinpty-py315", marker = "sys_platform == 'win32' and python_full_version >= '3.15'" },
# ]
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+67
to
+70
| # [[tool.uv.index]] | ||
| # name = "pywinpty-py315" | ||
| # url = "https://bckohan.github.io/pywinpty/simple/" | ||
| # explicit = true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge this until pywinpty has a python 3.15 build.