Skip to content

remove pywinpty py315 CI kludge - #307

Open
bckohan wants to merge 1 commit into
django-commons:mainfrom
bckohan:remove-winpty-fix
Open

remove pywinpty py315 CI kludge#307
bckohan wants to merge 1 commit into
django-commons:mainfrom
bckohan:remove-winpty-fix

Conversation

@bckohan

@bckohan bckohan commented Aug 8, 2026

Copy link
Copy Markdown
Member

Do not merge this until pywinpty has a python 3.15 build.

Copilot AI lite review requested due to automatic review settings August 8, 2026 08:42

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR disables (by commenting out) the custom uv index/source override that was previously used to install a Windows/Python 3.15-compatible pywinpty build, while expanding the surrounding comments explaining why that override exists.

Changes:

  • Expanded the explanatory comment describing the rationale for a custom pywinpty wheel/index for Python 3.15.
  • Commented out the [[tool.uv.index]] entry for the custom pywinpty-py315 index.
  • Commented out the [tool.uv.sources] mapping that directed Windows/Python>=3.15 to that custom index.
Suppressed comments (1)

pyproject.toml:75

  • With the pywinpty index commented out, this uv sources mapping is also disabled, so uv will no longer pull the Windows/Python>=3.15 build from the custom index. If the intent is to keep CI green for the existing Windows 3.15 job, this mapping needs to remain active until an upstream wheel exists.
# [tool.uv.sources]
# pywinpty = [
#   { index = "pywinpty-py315", marker = "sys_platform == 'win32' and python_full_version >= '3.15'" },
# ]

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread pyproject.toml
Comment on lines +67 to +70
# [[tool.uv.index]]
# name = "pywinpty-py315"
# url = "https://bckohan.github.io/pywinpty/simple/"
# explicit = true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants