Repository navigation
fix: read every path listed on an Include line - #3
Merged
Merged
Conversation
sshd_config(5) allows several space-separated paths on one Include line. The fallback parser treated the whole value as a single path, matched nothing, and silently dropped every setting from those files.
autoantohaki
force-pushed
the
fix/include-multiple-paths
branch
from
October 21, 2026 21:53
af38b4a to
9364298
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: an
Includeline listing several paths (for exampleInclude a.conf b.conf, allowed by sshd_config(5)) was treated as one path containing a space. Nothing matched, and every setting in those files was silently dropped from the fallback audit.After: each space-separated path on an
Includeline is read in order, with first-value-wins preserved.How: loop over
value.split()in theIncludebranch, with a test that includes two files on one line.Tests:
python -m unittest discover -s tests -v(new test fails onmain, passes here).