chore: Remove generator nodes - #2526
Merged
Merged
Conversation
trisyoungs
added a commit
that referenced
this pull request
Jun 23, 2026
RobBuchananCompPhys
approved these changes
Jun 24, 2026
rprospero
approved these changes
Jun 24, 2026
trisyoungs
force-pushed
the
dissolve2/remove-generator-nodes
branch
from
June 24, 2026 10:30
5f9deed to
fd0f41c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
Generatorclass and all of its associated nodes, plus a handful of keywords and models that were specific to them (which is nice!). The intention is to reintroduce a chunk of theGeneratorNodefunctionality (see #2502) but not right now as they block the removal of other things which we would like to get rid of sooner rather than later.