refactor: Add general export nodes, remove all remaining FileFormats - #2521
Merged
trisyoungs merged 10 commits intoJun 22, 2026
Conversation
trisyoungs
force-pushed
the
dissolve2/benchmarks-and-boxes
branch
from
June 19, 2026 12:23
1a82e28 to
26fdb33
Compare
trisyoungs
force-pushed
the
dissolve2/remove-unused-export-file-formats
branch
from
June 22, 2026 08:50
93d1e39 to
6589eed
Compare
rprospero
approved these changes
Jun 22, 2026
rprospero
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #2520 - do not merge until #2520 is complete
This PR adds in data export nodes in the form of
ExportDataNode(for XY(E), XYZ(E), and XYZW(E) data),ExportBlockData(for simple V(E) export of the same), andExportDLPUtilsPDensNode(the only specific file format we had).We completely remove the
FileAndFormatclass along with theio/directory and an associated keyword.