chore: Remove remaining modules - #2498
Merged
Merged
Conversation
…st (it relied on an input file but is mostly defunct anyway).
This was referenced Jun 11, 2026
trisyoungs
force-pushed
the
dissolve2/modify-charges-tests
branch
from
June 12, 2026 08:02
1e7af0b to
7906947
Compare
rprospero
approved these changes
Jun 12, 2026
rprospero
left a comment
rprospero
left a comment
Contributor
There was a problem hiding this comment.
This is certainly our largest net loss of lines. I think we did once have a PR that changed more lines, but it was +300k/-300k. I'm really curious how much this will improve compile times.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #2495 - do not merge until #2495 is complete
This PR removes the remaining modules and tidies up the remaining old input files. We begin!
Also note number of removed lines - over 100k! Is that a record? :)