fix: Replace gtest_discover_tests for Visual Studio 2022 builds - #2229
Merged
Merged
Conversation
trisyoungs
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DIssolve GTest unit tests have been failing to build in our Visual Studio 2022 (MSVC) setup. The failure appears to be related to a timeout at the link step* when GTest is attempting to run a test executable. I have found that swapping out the call to
gtest_discover_testswith the lower-level CTestadd_testgets around this hang, allow the tests to proceed to link and allows for running and debugging.*See the example below: