chore:Move to conan 2 - #2228
Merged
Merged
Conversation
rprospero
force-pushed
the
conan-2-rebase
branch
3 times, most recently
from
September 3, 2025 10:04
4c3a6af to
eb87da4
Compare
rprospero
force-pushed
the
conan-2-rebase
branch
from
September 3, 2025 15:00
eb87da4 to
ed1024c
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 2200d9b | Previous: 080eb63 | Ratio |
|---|---|---|---|
BM_Box_MinimumVector<CubicBox> |
10.603886618401043 ns/iter |
5.292752627757738 ns/iter |
2.00 |
BM_CalculateForces_SpeciesTorsion<SpeciesType::MediumMolecule, SpeciesPopulation::Small> |
667.6720667212232 ns/iter |
315.4423191484812 ns/iter |
2.12 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @disorderedmaterials/dissolve-devs
rprospero
force-pushed
the
conan-2-rebase
branch
from
September 3, 2025 16:46
e586fad to
bea8b4d
Compare
rprospero
force-pushed
the
conan-2-rebase
branch
from
September 4, 2025 10:56
f28b69a to
7f61f10
Compare
rprospero
marked this pull request as ready for review
September 4, 2025 12:14
trisyoungs
approved these changes
Sep 4, 2025
| conan profile update settings.compiler.version=17 default | ||
| conan profile detect | ||
| conan profile show | ||
| # -cc settings.compiler="Visual Studio" -cc settings.compiler.version=17 -cc core.download:download_cache="${GITHUB_WORKSPACE}/.conancache" |
Comment on lines
+8
to
+10
| gsl/2.7.1 | ||
| gtest/1.16.0 | ||
| benchmark/1.8.4 |
Member
There was a problem hiding this comment.
I guess we're happy with having these "unnecessary" dependencies pulled in all the time?
| assert(nColumns_ == B.nColumns_ && nRows_ == B.nRows_); | ||
|
|
||
| std::transform(array_.begin(), array_.end(), B.array_begin(), array_.begin(), [](auto &a, auto &b) { return a - b; }); | ||
| std::transform(array_.begin(), array_.end(), B.array_.begin(), array_.begin(), [](auto &a, auto &b) { return a - b; }); |
rprospero
added a commit
that referenced
this pull request
Sep 5, 2025
Co-authored-by: trisyoungs <tristan.youngs@stfc.ac.uk> Co-authored-by: Tristan Youngs <trisyoungs@googlemail.com>
rprospero
added a commit
that referenced
this pull request
Sep 15, 2025
Co-authored-by: trisyoungs <tristan.youngs@stfc.ac.uk> Co-authored-by: Tristan Youngs <trisyoungs@googlemail.com>
rprospero
added a commit
that referenced
this pull request
Feb 4, 2026
Co-authored-by: trisyoungs <tristan.youngs@stfc.ac.uk> Co-authored-by: Tristan Youngs <trisyoungs@googlemail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With GitHub actions moving to XCode 17, we're finally being forced to make the transition to Conan 2. The following changes were made to make this possible: