feat:Display enum parameters - #2210
Merged
Merged
Conversation
rprospero
force-pushed
the
enum_parameter
branch
from
July 25, 2025 13:39
444772c to
55fef9e
Compare
rprospero
force-pushed
the
enum_parameter
branch
from
July 25, 2025 14:03
55fef9e to
7de47b8
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: bec6b9c | Previous: fd90374 | Ratio |
|---|---|---|---|
BM_HistogramBinning_1d/16777216 |
24.554909903696107 ns/iter |
10.444396356764424 ns/iter |
2.35 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @disorderedmaterials/dissolve-devs
trisyoungs
approved these changes
Jul 28, 2025
trisyoungs
left a comment
trisyoungs
left a comment
Member
There was a problem hiding this comment.
This has come together really nicely, and I kinda like the centralised storage of models for different EnumOptions. Couple of minor suggesetions / comments, but otherwise all good.
| #include "gui/models/nodeGraph/enumOptionsModel.h" | ||
| #include "base/enumOptionsBase.h" | ||
|
|
||
| // Set source AtomType data |
Member
There was a problem hiding this comment.
No prizes for guessing where this code originated! :)
Co-authored-by: Tristan Youngs <tristan.youngs@stfc.ac.uk>
Co-authored-by: Tristan Youngs <tristan.youngs@stfc.ac.uk>
Co-authored-by: Tristan Youngs <tristan.youngs@stfc.ac.uk>
Co-authored-by: Tristan Youngs <tristan.youngs@stfc.ac.uk>
Co-authored-by: Tristan Youngs <tristan.youngs@stfc.ac.uk>
rprospero
marked this pull request as ready for review
August 1, 2025 10:06
Contributor
Author
|
@trisyoungs I thought it might be worth a second review before I merge to get a glimpse of the changes I made to disable the packaging. |
trisyoungs
approved these changes
Aug 1, 2025
rprospero
added a commit
that referenced
this pull request
Sep 5, 2025
Co-authored-by: Tristan Youngs <tristan.youngs@stfc.ac.uk>
trisyoungs
added a commit
that referenced
this pull request
Sep 10, 2025
Co-authored-by: Tristan Youngs <tristan.youngs@stfc.ac.uk>
RobBuchananCompPhys
pushed a commit
that referenced
this pull request
Sep 12, 2025
Co-authored-by: Tristan Youngs <tristan.youngs@stfc.ac.uk>
RobBuchananCompPhys
pushed a commit
that referenced
this pull request
Sep 25, 2025
Co-authored-by: Tristan Youngs <tristan.youngs@stfc.ac.uk>
rprospero
added a commit
that referenced
this pull request
Feb 4, 2026
Co-authored-by: Tristan Youngs <tristan.youngs@stfc.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR presents the user with a drop down for selecting enum values. This requires that the enum is included in the
EnumRegistry.As a side benefit of this PR, the options are now editable (they were previously read only). Additionally, it disables building the legacy GUI, though the tests remain.