refactor: Single configuration GR node and updated associates - #2204
Merged
Conversation
…o do this anyway as we need NeutronWeights.
trisyoungs
force-pushed
the
dissolve2/single-configuration-gr
branch
from
July 23, 2025 08:45
65f3d26 to
7a1733b
Compare
RobBuchananCompPhys
approved these changes
Jul 24, 2025
Co-authored-by: RobBuchanan <106311829+RobBuchananCompPhys@users.noreply.github.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 05be970 | Previous: 05bb033 | Ratio |
|---|---|---|---|
BM_HistogramBinning_1d/16777216 |
24.497625486546447 ns/iter |
11.218650361016083 ns/iter |
2.18 |
BM_HistogramBinning_2d/16777216 |
45.473450867297316 ns/iter |
21.48302218564237 ns/iter |
2.12 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @disorderedmaterials/dissolve-devs
rprospero
pushed a commit
that referenced
this pull request
Sep 5, 2025
Co-authored-by: Tristan Youngs <trisyoungs@googlemail.com> Co-authored-by: RobBuchanan <106311829+RobBuchananCompPhys@users.noreply.github.com>
rprospero
pushed a commit
that referenced
this pull request
Feb 4, 2026
Co-authored-by: Tristan Youngs <trisyoungs@googlemail.com> Co-authored-by: RobBuchanan <106311829+RobBuchananCompPhys@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ahead of #2203 it was worthwhile taking a step back and refactoring the
GRNodeto take a singleConfigurationinput rather than astd::vector. CombiningGRresults is a job for a separate node in the new scheme of things.At the same time I have updated
SQNodeandNeutronSQNodeand clarified the two separate "species population" maps we have - one with only ever integer populations coming from aConfiguration, and one with only ever real populations coming from aPartialSet(which will occur when we start mixingGRresults in the future).