build: Refactor Powershell script for Visual Studio setup - #2191
Merged
Conversation
RobBuchananCompPhys
changed the title
…der one should be used
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 1eaa533 | Previous: c4ae8aa | Ratio |
|---|---|---|---|
BM_HistogramBinning_1d/16777216 |
29.713492718825243 ns/iter |
10.162923407525236 ns/iter |
2.92 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @disorderedmaterials/dissolve-devs
RobBuchananCompPhys
marked this pull request as ready for review
July 3, 2025 08:54
trisyoungs
approved these changes
Jul 3, 2025
trisyoungs
left a comment
trisyoungs
left a comment
Member
There was a problem hiding this comment.
Looks good. Couple of comments, and one feature suggestion: if I want to use a system Qt perhaps the -systemqt option could take the path to the Qt installation and inject the correct Qt6_DIR definition into the CMakeUserPresets file?
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMakePresets.json"environment" property