DEV: Gate gem publishing on the mutation job#48
Merged
Conversation
The publish job only waited for lint and test, so a release could go out while (or even though) the mutation job was still running or failing on the same push. Add mutation to its needs list. On pushes to main — the only ref publish runs on — the mutation job always runs, so the skipped-needs propagation rule never skips publish.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
publishjob only waited forlintandtest, so a gem release could go out while themutationjob was still running — or even after it failed — on the same push tomain(seen on the v0.2.0 release, wherepublishfinished beforemutation).Add
mutationto theneedslist. On pushes tomain— the only refpublishruns on — the mutation job always runs, so the skipped-needs propagation rule never skipspublish.