Skip to content

[Discord] Enable preventShadowTreeCommitExhaustion by default #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
piaskowyk wants to merge 1 commit into
base: 0.86.0-discord
Choose a base branch
from
Open

[Discord] Enable preventShadowTreeCommitExhaustion by default #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<462ac270e53d73922c29341d2bf557cc>>
* @generated SignedSource<<e9744b91685d8070fab1f75e41d45519>>
*/

/**
Expand Down Expand Up @@ -165,7 +165,7 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi

override fun preparedTextCacheSize(): Double = 200.0

override fun preventShadowTreeCommitExhaustion(): Boolean = false
override fun preventShadowTreeCommitExhaustion(): Boolean = true

override fun redBoxV2Android(): Boolean = false

Expand Down
4 changes: 2 additions & 2 deletions packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsDefaults.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<d2a632a098313bbafabfdc9ee52efdbb>>
* @generated SignedSource<<5601de29c2a1e4bb3ff623d91f02c5f5>>
*/

/**
Expand Down Expand Up @@ -312,7 +312,7 @@ class ReactNativeFeatureFlagsDefaults : public ReactNativeFeatureFlagsProvider {
}

bool preventShadowTreeCommitExhaustion() override {
return false;
return true;
}

bool redBoxV2Android() override {
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -807,7 +807,7 @@ const definitions: FeatureFlagDefinitions = {
ossReleaseStage: 'none',
},
preventShadowTreeCommitExhaustion: {
defaultValue: false,
defaultValue: true,
metadata: {
dateAdded: '2025-07-23',
description:
Expand Down
4 changes: 2 additions & 2 deletions packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<cffc01d719cbe277b0663bc53798f525>>
* @generated SignedSource<<555adeda70df7c9d17408eb7ad987aa2>>
* @flow strict
* @noformat
*/
Expand Down Expand Up @@ -499,7 +499,7 @@ export const preparedTextCacheSize: Getter<number> = createNativeFlagGetter('pre
/**
* Enables a new mechanism in ShadowTree to prevent problems caused by multiple threads trying to commit concurrently. If a thread tries to commit a few times unsuccessfully, it will acquire a lock and try again.
*/
export const preventShadowTreeCommitExhaustion: Getter<boolean> = createNativeFlagGetter('preventShadowTreeCommitExhaustion', false);
export const preventShadowTreeCommitExhaustion: Getter<boolean> = createNativeFlagGetter('preventShadowTreeCommitExhaustion', true);
/**
* Use the redesigned RedBox error overlay on Android, styled to match the LogBox visual language.
*/
Expand Down