Repository navigation
[Discord] Drop the renderer architecture from the constants cache key - #50
Merged
Merged
Conversation
The key combined the app version with the renderer architecture, the latter read from ReactNativeFeatureFlags. init() runs from whichever of Application or ReactActivity.onCreate reaches it first, so an Activity created before the host app has applied its own ReactNativeFeatureFlags override performs that read first, and React Native then refuses the override for the life of the process. The app is Fabric-only, so the architecture cannot vary within an app version, and the app version is already part of the key.
joemun
marked this pull request as ready for review
September 11, 2026 19:55
Flewp
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cache keyed on app version plus renderer architecture, reading the architecture from ReactNativeFeatureFlags. RN only accepts override() before any flag is read, and init() runs from whichever of Application or ReactActivity.onCreate gets there first, so an Activity created before the app applies its override wins the race and the override is refused. The app applies it in a FutureTask, so every consumer rethrows it for the rest of the process.
Unnecessary since we're on Fabric now.