Repository navigation
Soft-deprecate discover consensus and enhanced - #46
Merged
yudelevi merged 3 commits intoOct 19, 2026
Merged
Conversation
The platform now decides consensus itself and no longer runs AI result enhancement, so both discover request fields are ignored. The regenerated DiscoverParams drops them; passing either still sends it and raises a DeprecationWarning, scoped to discover so contacts consensus is untouched. CLI help for --consensus, --enhanced and --variance says what the server does now.
The dev spec's ProspectingRunResponse gained question, the ProspectingOpenQuestion a needs_input run waits on; without it the contract check against dev fails for every PR.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The platform now applies consensus itself (single-domain lookalike searches without ICP text) and no longer runs AI result enhancement (platform !1024 / !1025, live on dev). Both discover request fields are accepted and ignored.
_generated/requests.pyis regenerated from the dev spec.DiscoverParamsdropsconsensusandenhanced, andvariancedescribes where a list stops.DeprecationWarning. The warning is scoped toDiscoverParamsthrough a new per-model table next toDEPRECATED_REQUEST_FIELDS, so contactsconsensusis untouched.--consensusand--enhancedondiscoversay deprecated/no-op, and--variance(discover, bulk) describes the stop.ProspectingRunResponsegainedquestion(ProspectingOpenQuestion, what a needs_input run waits on). Without it the dev contract check fails for every PR, soProspectingRun.questionis declared here, with a test.Checks against the dev spec:
gen_requests.py --checkis up to date andcheck_contract.pymatches. 936 tests pass.Changelog entries are left for release prep. The docs follow-up (discolike-api-docs, SDK reference rows) merges after this, since docs CI validates against this repo's development branch.
The PR appears safe to merge, with the previous CLI help issue fixed.Summary
Soft-deprecates discover's
consensusandenhancedfields while keeping supplied values in outgoing requests.consensusorenhanced.The changes since the previous review only restore the missing CLI choices. No new actionable issues were found.
Reviews (2) · Last reviewed commit: "fix(cli): list every variance level in t..." · Reviewed by Greptile