Skip to content

CLI: prospecting plan command - #42

Merged
yudelevi merged 2 commits into
developmentfrom
feat/cli-prospecting-plan
Oct 7, 2026
Merged

yudelevi merged 2 commits into
developmentfrom
feat/cli-prospecting-plan

Conversation

@yudelevi

@yudelevi yudelevi commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor
  • Adds discolike prospecting plan RUN_ID --plan-version N wrapping update_plan, so CLI users can pick an engine the plan left unselected (selected: null) and approve; the API returns 409 on approve until one is picked.
  • Also covers resizing and spend limits without restarting the run; only passed flags are sent.

RetriggerConfidence Score: 4/5

The PR appears safe to merge, with a non-blocking improvement to the returned-version test.

Fix All in Claude CodeFindings

  1. P2 Updated version goes unchecked ▶
Fix with agent prompt
### Issue 1
packages/discolike-cli/tests/test_prospecting_cli.py:469
Both new `plan` tests return a response without `plan_version` and never check the version printed to stdout. `ProspectingRun` fills in `1`, so the tests pass even though their requests use versions `2` and `3`. Return an explicitly newer version from the test handler and assert it in stdout. This protects the value users need for their next `approve` command.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

Adds prospecting plan to change engines, counts, deliverables, goals, and spending limits before approval.

  • Requires the reviewed plan_version and sends only supplied flags.
  • Prints the updated run and documents approving its new version.
  • Adds request and input checks. One non-blocking test improvement would protect the returned version.

Reviews (1) · Last reviewed commit: "Add prospecting plan command to the CLI" · Reviewed by Greptile

The API now leaves a plan's contact engine, company check engine or
search provider unselected when an organization has several providers
and none is the default, and approve returns 409 until one is picked.
The SDK already wraps PATCH /prospecting/runs/{id}/plan, but CLI users
had no way to reach it, so such a run could not be approved from the
CLI. `prospecting plan` forwards every ProspectingPlanSettings field and
sends only the flags passed, so it also covers resizing and spend
limits without restarting the run.
The plan tests' responses had no plan_version, so the model's default
of 1 hid whether the new version reached stdout; users need that value
for their next approve.
@yudelevi
yudelevi force-pushed the feat/cli-prospecting-plan branch from 4ef40ba to cf9ae95 Compare October 7, 2026 23:22
@yudelevi
yudelevi merged commit 01a12c1 into development Oct 7, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant