Skip to content

refactor: simplify dependency key handling in syncPackageEngineWithDependency script #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gorniaky merged 1 commit into from
Aug 7, 2026
Merged

refactor: simplify dependency key handling in syncPackageEngineWithDependency script #987

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions scripts/syncPackageEngineWithDependency.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,6 @@ import { readFile, writeFile } from "fs/promises";
const ENCODING = "utf8";
const INDENTATION = 2;
const PACKAGE_PATH = "package.json";
/** @type {keyof import("type-fest").PackageJson} */
const PACKAGE_DEPENDENCY_KEYS = [
"dependencies",
"bundleDependencies",
"bundledDependencies",
"devDependencies",
"optionalDependencies",
"peerDependencies",
];

const [, , engine, dependency] = process.argv;

Expand All @@ -26,9 +17,11 @@ packageJSON.engines ??= {};

const oldEngineVersion = packageJSON.engines[engine];

const packageDependencyKeyPattern = /^(?:(?:bundled?|dev|optional|peer)D|d)ependencies$/;

let found = false, updated = false;
for (const key of PACKAGE_DEPENDENCY_KEYS) {
if (!(key in packageJSON) || !(dependency in packageJSON[key])) continue;
for (const key in packageJSON) {
if (!packageDependencyKeyPattern.test(key) || !(dependency in packageJSON[key])) continue;
found = true;
if (oldEngineVersion === packageJSON[key][dependency]) break;
packageJSON.engines[engine] = packageJSON[key][dependency];
Expand Down
Loading