docs(roadmap): add Track F code-quality audit findings - #75
Merged
Conversation
…ions Adds Track F summarizing the implementation-quality audit against pi + opencode. 20 findings split into: - F1–F2 CRITICAL: ACP perm asks dropped (functional break in Zed mode); hidden files exposed by find_files/glob/list_dir (.env, .git/, .DS_Store leak — security) - F3–F10 HIGH: compress cut-point can split tool_use pairs; read 10MB cap with no streaming; ACP parallel tool id correlation; bash no process-group cleanup; symlink canonicalization in permission check_path; no session schema versioning; mid-stream decode retry blocked by had_tool_calls; bash fallback splitter doesn't respect quotes (no-default-features only) - F11–F20 MEDIUM: edit overlap detection, bash interleaving, compress token math, retry-after header, partial-on-abort tool state, plugin load order, context mutability docs, relative- path normalization, BOM stripping, unbounded interjection channel - F-SKIP: 6 verified false positives documented so future audits don't re-raise them Each finding cites the dirge file:line and the corresponding pi/opencode pattern. Ordering recommendation: ship F1+F2 first, then F3–F10 as a TDD'd PR series, then F11–F20 batched. Also includes user's own annotations at the top (bugs noted: intermittent avatar duplication on scroll; minor UI polish: user vs dirge message colors, "no output" chamber styling, post- alert box top-cut; table alignment) plus per-phase "planned?" column annotations on Tracks A–E.
allen-munsch
pushed a commit
to allen-munsch/dirge
that referenced
this pull request
Jun 3, 2026
…ions (dirge-code#75) Adds Track F summarizing the implementation-quality audit against pi + opencode. 20 findings split into: - F1–F2 CRITICAL: ACP perm asks dropped (functional break in Zed mode); hidden files exposed by find_files/glob/list_dir (.env, .git/, .DS_Store leak — security) - F3–F10 HIGH: compress cut-point can split tool_use pairs; read 10MB cap with no streaming; ACP parallel tool id correlation; bash no process-group cleanup; symlink canonicalization in permission check_path; no session schema versioning; mid-stream decode retry blocked by had_tool_calls; bash fallback splitter doesn't respect quotes (no-default-features only) - F11–F20 MEDIUM: edit overlap detection, bash interleaving, compress token math, retry-after header, partial-on-abort tool state, plugin load order, context mutability docs, relative- path normalization, BOM stripping, unbounded interjection channel - F-SKIP: 6 verified false positives documented so future audits don't re-raise them Each finding cites the dirge file:line and the corresponding pi/opencode pattern. Ordering recommendation: ship F1+F2 first, then F3–F10 as a TDD'd PR series, then F11–F20 batched. Also includes user's own annotations at the top (bugs noted: intermittent avatar duplication on scroll; minor UI polish: user vs dirge message colors, "no output" chamber styling, post- alert box top-cut; table alignment) plus per-phase "planned?" column annotations on Tracks A–E. Co-authored-by: Yogthos <yogthos@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds 20 quality-audit findings to ROADMAP.md split by severity (F-CRITICAL/HIGH/MEDIUM/SKIP), each citing dirge file:line and the pi/opencode reference pattern. Ordering: F1+F2 first, then F3-F10 as a TDD series, F11-F20 batched. Also incorporates user annotations on bugs and UI polish items at the top of the file.