Phase 4: Background Review at Session End - #139
Merged
Conversation
added 2 commits
May 25, 2026 22:51
Port of Hermes's agent/background_review.py. After every session completes (and no plugin followup or loop iteration claims the next turn), a background review fork evaluates the transcript and writes project learnings. Features: - Fire-and-forget tokio::spawn — never blocks the user - Forked agent with memory + skill tools only (spawn_review_runner filters loop_tools to just 'memory' and 'skill') - Coding-specific review prompts covering memory (MEMORY.md, PITFALLS.md) and skills (create, edit, patch) - Same provider/credentials as parent session - Errors logged via tracing, never surfaced to user - review_provider + review_model config fields for routing review work to a cheaper/faster model (optional) Integration: triggers from the Done event handler when the session is truly idle (is_running=false). All 1216 tests pass.
allen-munsch
pushed a commit
to allen-munsch/dirge
that referenced
this pull request
Jun 3, 2026
…review Phase 4: Background Review at Session End
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of Hermes's agent/background_review.py. After every session completes and is truly idle, a background review fork evaluates the transcript and writes project learnings.
Features:
Integration: triggers from Done event handler when session is idle.