Skip to content

Default enabled line wrapping and support wrap md syntax#974

Merged
HelenVirtanen merged 2 commits into
masterfrom
fix-md-syntax-wrap-codeblock
Jul 8, 2026
Merged

Default enabled line wrapping and support wrap md syntax#974
HelenVirtanen merged 2 commits into
masterfrom
fix-md-syntax-wrap-codeblock

Conversation

@HelenVirtanen

Copy link
Copy Markdown
Contributor

Added md syntax to enable/disable wrap in codeblocks
Enable default wrap in codeblocks

@HelenVirtanen HelenVirtanen requested review from a team and diplodoc-bot as code owners July 8, 2026 13:35
@HelenVirtanen HelenVirtanen requested review from Yurok868 and reazy015 and removed request for a team and reazy015 July 8, 2026 13:35
@yc-ui-bot

Copy link
Copy Markdown
Contributor

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
189 169 0 20 0 0 1m 55s

🎉 No failed tests in this run.

Github Test Reporter by CTRF 💚

@HelenVirtanen HelenVirtanen requested a review from reazy015 July 8, 2026 13:41
Comment thread src/transform/plugins/code.ts Outdated
{lineWrapping, isWrapped = true}: {lineWrapping: boolean; isWrapped: boolean},
) => {
const activeClass = isWrapped ? ' g-button_selected' : '';
const ariaPressed = isWrapped ? 'true' : 'false';

@reazy015 reazy015 Jul 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks redundant, what if just leave expression - const ariaPressed = isWrapped ?

@HelenVirtanen HelenVirtanen force-pushed the fix-md-syntax-wrap-codeblock branch from 4a2d1c2 to e201c95 Compare July 8, 2026 14:22
@yc-ui-bot

Copy link
Copy Markdown
Contributor

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
189 169 0 20 0 0 1m 54s

🎉 No failed tests in this run.

Github Test Reporter by CTRF 💚

@HelenVirtanen HelenVirtanen force-pushed the fix-md-syntax-wrap-codeblock branch from e201c95 to 03a8029 Compare July 8, 2026 15:12
@yc-ui-bot

Copy link
Copy Markdown
Contributor

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
189 160 9 20 0 1 2m 29s

Failed Tests

Failed Tests ❌ Fail Message
❌ code block visual regression Error: expect(Buffer).toMatchSnapshot(expected) failed

Expected an image 568px by 72px, received 568px by 92px. 1456 pixels (ratio 0.03 of all image pixels) are different.

Snapshot: long-content-code-block.png
❌ code block visual regression on hover Error: expect(Buffer).toMatchSnapshot(expected) failed

Expected an image 568px by 72px, received 568px by 92px. 1457 pixels (ratio 0.03 of all image pixels) are different.

Snapshot: long-content-code-block-hover.png
❌ code block visual regression after toggle text wrapping Error: expect(Buffer).toMatchSnapshot(expected) failed

Expected an image 568px by 92px, received 568px by 72px. 1457 pixels (ratio 0.03 of all image pixels) are different.

Snapshot: long-content-code-block-text-wrapping.png
❌ code block visual regression Error: expect(Buffer).toMatchSnapshot(expected) failed

Expected an image 568px by 72px, received 568px by 92px. 942 pixels (ratio 0.02 of all image pixels) are different.

Snapshot: long-content-code-block.png
❌ code block visual regression on hover Error: expect(Buffer).toMatchSnapshot(expected) failed

Expected an image 568px by 72px, received 568px by 92px. 946 pixels (ratio 0.02 of all image pixels) are different.

Snapshot: long-content-code-block-hover.png
❌ code block visual regression after toggle text wrapping Error: expect(Buffer).toMatchSnapshot(expected) failed

Expected an image 568px by 92px, received 568px by 72px. 946 pixels (ratio 0.02 of all image pixels) are different.

Snapshot: long-content-code-block-text-wrapping.png
❌ code block visual regression Error: expect(Buffer).toMatchSnapshot(expected) failed

Expected an image 1136px by 144px, received 1136px by 184px. 3955 pixels (ratio 0.02 of all image pixels) are different.

Snapshot: long-content-code-block.png
❌ code block visual regression on hover Error: expect(Buffer).toMatchSnapshot(expected) failed

Expected an image 1136px by 144px, received 1136px by 184px. 3899 pixels (ratio 0.02 of all image pixels) are different.

Snapshot: long-content-code-block-hover.png
❌ code block visual regression after toggle text wrapping Error: expect(Buffer).toMatchSnapshot(expected) failed

Expected an image 1136px by 184px, received 1136px by 144px. 3899 pixels (ratio 0.02 of all image pixels) are different.

Snapshot: long-content-code-block-text-wrapping.png

Github Test Reporter by CTRF 💚

@sonarqubecloud

sonarqubecloud Bot commented Jul 8, 2026

Copy link
Copy Markdown

@yc-ui-bot

Copy link
Copy Markdown
Contributor

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
189 169 0 20 0 0 1m 41s

🎉 No failed tests in this run.

Github Test Reporter by CTRF 💚

@HelenVirtanen HelenVirtanen merged commit 2ec3c10 into master Jul 8, 2026
10 checks passed
@HelenVirtanen HelenVirtanen deleted the fix-md-syntax-wrap-codeblock branch July 8, 2026 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants