fix: edit click on codeblock buttons by HelenVirtanen · Pull Request #970 · diplodoc-platform/transform

HelenVirtanen · 2026-07-07T14:17:27Z

Fix code block floating button clicks after the markup update to the Gravity UI button structure.

yc-ui-bot · 2026-07-07T14:21:34Z

Summary

Tests 📝	Passed ✅	Failed ❌	Skipped ⏭️	Other ❓	Flaky 🍂	Duration ⏱️
189	163	6	20	0	0	2m 19s

Failed Tests

Failed Tests ❌	Fail Message
❌ code block visual regression after click copy button	Error: expect(Buffer).toMatchSnapshot(expected) failed 4 pixels (ratio 0.01 of all image pixels) are different. Snapshot: base-code-block-copied.png
❌ code block visual regression after toggle text wrapping	Error: expect(Buffer).toMatchSnapshot(expected) failed Expected an image 568px by 72px, received 568px by 92px. 1457 pixels (ratio 0.03 of all image pixels) are different. Snapshot: long-content-code-block-text-wrapping.png
❌ code block visual regression after click copy button	Error: expect(Buffer).toMatchSnapshot(expected) failed 4 pixels (ratio 0.01 of all image pixels) are different. Snapshot: base-code-block-copied.png
❌ code block visual regression after toggle text wrapping	Error: expect(Buffer).toMatchSnapshot(expected) failed Expected an image 568px by 72px, received 568px by 92px. 946 pixels (ratio 0.02 of all image pixels) are different. Snapshot: long-content-code-block-text-wrapping.png
❌ code block visual regression after click copy button	Error: expect(Buffer).toMatchSnapshot(expected) failed 11 pixels (ratio 0.01 of all image pixels) are different. Snapshot: base-code-block-copied.png
❌ code block visual regression after toggle text wrapping	Error: expect(Buffer).toMatchSnapshot(expected) failed Expected an image 1136px by 144px, received 1136px by 184px. 3899 pixels (ratio 0.02 of all image pixels) are different. Snapshot: long-content-code-block-text-wrapping.png

Github Test Reporter by CTRF 💚

yc-ui-bot · 2026-07-07T14:55:26Z

Summary

Tests 📝	Passed ✅	Failed ❌	Skipped ⏭️	Other ❓	Flaky 🍂	Duration ⏱️
189	169	0	20	0	1	1m 58s

_{🎉 No failed tests in this run.}

Github Test Reporter by CTRF 💚

yc-ui-bot · 2026-07-07T15:01:33Z

Summary

Tests 📝	Passed ✅	Failed ❌	Skipped ⏭️	Other ❓	Flaky 🍂	Duration ⏱️
189	163	6	20	0	0	2m 23s

Failed Tests

Failed Tests ❌	Fail Message
❌ code block visual regression after click copy button	Error: expect(Buffer).toMatchSnapshot(expected) failed 4 pixels (ratio 0.01 of all image pixels) are different. Snapshot: base-code-block-copied.png
❌ code block visual regression after toggle text wrapping	Error: expect(Buffer).toMatchSnapshot(expected) failed Expected an image 568px by 72px, received 568px by 92px. 1457 pixels (ratio 0.03 of all image pixels) are different. Snapshot: long-content-code-block-text-wrapping.png
❌ code block visual regression after click copy button	Error: expect(Buffer).toMatchSnapshot(expected) failed 4 pixels (ratio 0.01 of all image pixels) are different. Snapshot: base-code-block-copied.png
❌ code block visual regression after toggle text wrapping	Error: expect(Buffer).toMatchSnapshot(expected) failed Expected an image 568px by 72px, received 568px by 92px. 946 pixels (ratio 0.02 of all image pixels) are different. Snapshot: long-content-code-block-text-wrapping.png
❌ code block visual regression after click copy button	Error: expect(Buffer).toMatchSnapshot(expected) failed 11 pixels (ratio 0.01 of all image pixels) are different. Snapshot: base-code-block-copied.png
❌ code block visual regression after toggle text wrapping	Error: expect(Buffer).toMatchSnapshot(expected) failed Expected an image 1136px by 144px, received 1136px by 184px. 3899 pixels (ratio 0.02 of all image pixels) are different. Snapshot: long-content-code-block-text-wrapping.png

Github Test Reporter by CTRF 💚

yc-ui-bot · 2026-07-07T15:49:42Z

Summary

Tests 📝	Passed ✅	Failed ❌	Skipped ⏭️	Other ❓	Flaky 🍂	Duration ⏱️
189	169	0	20	0	0	1m 58s

_{🎉 No failed tests in this run.}

Github Test Reporter by CTRF 💚

reazy015 · 2026-07-07T16:09:42Z

 function buttonWrapFn(target: HTMLElement) {
-    const container = target.parentNode?.parentNode;
+    const button = target.closest<HTMLElement>(WRAP_BUTTON_SELECTOR);
+    const container = button?.closest<HTMLElement>('.yfm-code-floating-container');


.yfm-code-floating-container - it could be a const variable like WRAP_BUTTON_SELECTOR

yc-ui-bot · 2026-07-07T16:31:24Z

Summary

Tests 📝	Passed ✅	Failed ❌	Skipped ⏭️	Other ❓	Flaky 🍂	Duration ⏱️
189	163	6	20	0	0	2m 19s

Failed Tests

Failed Tests ❌	Fail Message
❌ code block visual regression after click copy button	Error: expect(Buffer).toMatchSnapshot(expected) failed 4 pixels (ratio 0.01 of all image pixels) are different. Snapshot: base-code-block-copied.png
❌ code block visual regression after toggle text wrapping	Error: expect(Buffer).toMatchSnapshot(expected) failed Expected an image 568px by 72px, received 568px by 92px. 1457 pixels (ratio 0.03 of all image pixels) are different. Snapshot: long-content-code-block-text-wrapping.png
❌ code block visual regression after click copy button	Error: expect(Buffer).toMatchSnapshot(expected) failed 4 pixels (ratio 0.01 of all image pixels) are different. Snapshot: base-code-block-copied.png
❌ code block visual regression after toggle text wrapping	Error: expect(Buffer).toMatchSnapshot(expected) failed Expected an image 568px by 72px, received 568px by 92px. 946 pixels (ratio 0.02 of all image pixels) are different. Snapshot: long-content-code-block-text-wrapping.png
❌ code block visual regression after click copy button	Error: expect(Buffer).toMatchSnapshot(expected) failed 11 pixels (ratio 0.01 of all image pixels) are different. Snapshot: base-code-block-copied.png
❌ code block visual regression after toggle text wrapping	Error: expect(Buffer).toMatchSnapshot(expected) failed Expected an image 1136px by 144px, received 1136px by 184px. 3899 pixels (ratio 0.02 of all image pixels) are different. Snapshot: long-content-code-block-text-wrapping.png

Github Test Reporter by CTRF 💚

yc-ui-bot · 2026-07-07T17:58:33Z

Summary

Tests 📝	Passed ✅	Failed ❌	Skipped ⏭️	Other ❓	Flaky 🍂	Duration ⏱️
189	163	6	20	0	0	2m 28s

Failed Tests

Failed Tests ❌	Fail Message
❌ code block visual regression after click copy button	Error: expect(Buffer).toMatchSnapshot(expected) failed 4 pixels (ratio 0.01 of all image pixels) are different. Snapshot: base-code-block-copied.png
❌ code block visual regression after toggle text wrapping	Error: expect(Buffer).toMatchSnapshot(expected) failed Expected an image 568px by 72px, received 568px by 92px. 1457 pixels (ratio 0.03 of all image pixels) are different. Snapshot: long-content-code-block-text-wrapping.png
❌ code block visual regression after click copy button	Error: expect(Buffer).toMatchSnapshot(expected) failed 4 pixels (ratio 0.01 of all image pixels) are different. Snapshot: base-code-block-copied.png
❌ code block visual regression after toggle text wrapping	Error: expect(Buffer).toMatchSnapshot(expected) failed Expected an image 568px by 72px, received 568px by 92px. 946 pixels (ratio 0.02 of all image pixels) are different. Snapshot: long-content-code-block-text-wrapping.png
❌ code block visual regression after click copy button	Error: expect(Buffer).toMatchSnapshot(expected) failed 11 pixels (ratio 0.01 of all image pixels) are different. Snapshot: base-code-block-copied.png
❌ code block visual regression after toggle text wrapping	Error: expect(Buffer).toMatchSnapshot(expected) failed Expected an image 1136px by 144px, received 1136px by 184px. 3899 pixels (ratio 0.02 of all image pixels) are different. Snapshot: long-content-code-block-text-wrapping.png

Github Test Reporter by CTRF 💚

sonarqubecloud · 2026-07-07T18:13:56Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

yc-ui-bot · 2026-07-07T18:16:33Z

Summary

Tests 📝	Passed ✅	Failed ❌	Skipped ⏭️	Other ❓	Flaky 🍂	Duration ⏱️
189	169	0	20	0	0	2m 4s

_{🎉 No failed tests in this run.}

Github Test Reporter by CTRF 💚

HelenVirtanen requested a review from reazy015 July 7, 2026 14:17

HelenVirtanen requested review from a team and diplodoc-bot as code owners July 7, 2026 14:17

HelenVirtanen force-pushed the fix-buttons-wrap-copy branch from 08f8d7d to b940933 Compare July 7, 2026 14:51

HelenVirtanen force-pushed the fix-buttons-wrap-copy branch from b940933 to d26c5a0 Compare July 7, 2026 14:57

reazy015 approved these changes Jul 7, 2026

View reviewed changes

HelenVirtanen force-pushed the fix-buttons-wrap-copy branch from 98c3cef to f22ff36 Compare July 7, 2026 16:27

fix: edit click on codeblock buttons

5bf58d8

HelenVirtanen force-pushed the fix-buttons-wrap-copy branch from f22ff36 to 5bf58d8 Compare July 7, 2026 17:53

fix: update snapshots

e459dba

HelenVirtanen merged commit ff4c0f3 into master Jul 7, 2026
10 checks passed

HelenVirtanen deleted the fix-buttons-wrap-copy branch July 7, 2026 18:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: edit click on codeblock buttons#970

fix: edit click on codeblock buttons#970
HelenVirtanen merged 2 commits into
masterfrom
fix-buttons-wrap-copy

HelenVirtanen commented Jul 7, 2026

Uh oh!

yc-ui-bot commented Jul 7, 2026

Uh oh!

yc-ui-bot commented Jul 7, 2026

Uh oh!

yc-ui-bot commented Jul 7, 2026

Uh oh!

yc-ui-bot commented Jul 7, 2026

Uh oh!

reazy015 Jul 7, 2026

Uh oh!

yc-ui-bot commented Jul 7, 2026

Uh oh!

yc-ui-bot commented Jul 7, 2026

Uh oh!

sonarqubecloud Bot commented Jul 7, 2026

Uh oh!

yc-ui-bot commented Jul 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

HelenVirtanen commented Jul 7, 2026

Uh oh!

yc-ui-bot commented Jul 7, 2026

Summary

Failed Tests

Uh oh!

yc-ui-bot commented Jul 7, 2026

Summary

Uh oh!

yc-ui-bot commented Jul 7, 2026

Summary

Failed Tests

Uh oh!

yc-ui-bot commented Jul 7, 2026

Summary

Uh oh!

reazy015 Jul 7, 2026

Choose a reason for hiding this comment

Uh oh!

yc-ui-bot commented Jul 7, 2026

Summary

Failed Tests

Uh oh!

yc-ui-bot commented Jul 7, 2026

Summary

Failed Tests

Uh oh!

sonarqubecloud Bot commented Jul 7, 2026

Quality Gate passed

Uh oh!

yc-ui-bot commented Jul 7, 2026

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants