Skip to content

replace table_exists? with data_source_exists? - #37

Open
isaiah wants to merge 1 commit into
diogob:masterfrom
isaiah:fix_for_materialized_view
Open

replace table_exists? with data_source_exists?#37
isaiah wants to merge 1 commit into
diogob:masterfrom
isaiah:fix_for_materialized_view

Conversation

@isaiah

@isaiah isaiah commented Apr 18, 2018

Copy link
Copy Markdown
Contributor

Since Rails5, table_exists? only works for tables, which makes acts_as_geolocated fail on materialized views.

http://guides.rubyonrails.org/5_0_release_notes.html#active-record-deprecations

@diogob

diogob commented Apr 18, 2018

Copy link
Copy Markdown
Owner

Thanks for the PR @isaiah

Could you add a test case that would fail in the current code base? Creating a materialized view in the spec_helper should be quite straightforward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants