Replace MutableMap with CAccountMap NIF for fast State.clone#37
Merged
Conversation
Store accounts in a native C++ map with COW semantics so State.clone avoids per-account ETS iteration and Account struct allocation (~5s to ~2ms at 14k accounts). Co-authored-by: Cursor <cursoragent@cursor.com>
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CAccountMap) inmerkletree_nif.sowith COW semantics matchingCMerkleTree, holding nonce, balance, storage trie ref, and code per address.Chain.StatefromMutableMaptoCAccountMapsoState.clone/1is a single NIF call instead of iterating ~14k accounts through ETS +Account.clone.mutable_mapdependency; compact DB states still use plainMapat serialization boundaries.Performance
Benchmark at ~14,609 accounts (same scale as the profiled
Shell.call_txpath):State.clone(ETS fold + per-accountCMerkleTree.clone+MutableMap.put)CAccountMap.clone/1)Test plan
mix test test/caccount_map_test.exsmix test test/chain_state_merkle_test.exs(COW round-trip / difference)mix test test/cmerkletree_test.exsmake -C c_src nif/make -C c_src nif-asanShell.call_txon production-scale state in stagingMade with Cursor