fix(mcp): pair @vitejs/plugin-vue 6 with vite 8 - #310
Merged
Conversation
main is currently red: mcp-ci fails on every push since 6c6f39b (#240, vite 6.4.3 -> 8.1.5 in plugins/mcp/web). `npm ci` cannot resolve the tree at all: npm error Found: vite@8.1.5 npm error peer vite@"^5.0.0 || ^6.0.0" from @vitejs/plugin-vue@5.2.4 plugin-vue 5.x caps at vite 6; 6.0.8 widens the peer range to `^5 || ^6 || ^7 || ^8`. The two must move together. This pairing was pushed to #240's branch before it merged, but a later `@dependabot recreate` on that PR rebuilt the branch from the bump alone and dropped it, so #240 landed with vite 8 and plugin-vue 5. Verified on this branch: `npm ci` succeeds (the exact CI command) and `npm run build` passes. The incus web app took the same pairing separately via #238.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main is red.
mcp-cihas failed on every push since6c6f39b(#240, vite 6.4.3 → 8.1.5 inplugins/mcp/web).npm cicannot resolve the tree at all:plugin-vue 5.x caps at vite 6; 6.0.8 widens the peer range to
^5 || ^6 || ^7 || ^8. The two have to move together.How it got in
I pushed exactly this pairing to #240's branch before it merged. Later I ran
@dependabot recreateon #240 to clear a merge conflict — that rebuilt the branch from the bump alone and silently dropped the pairing commit, so #240 landed with vite 8 and plugin-vue 5. My mistake:recreatediscards any commits pushed onto a dependabot branch.Verification
On this branch, both of the exact commands
mcp-ciruns:npm ci --no-audit --no-fund --prefix web→ succeeds (fails on main)npm run build --prefix web→ passesThe incus web app took the same pairing separately in #238, which is why only
plugins/mcp/webis affected.Also unblocks #267, whose
mcpcheck is failing purely on this inherited breakage.