Centralize log paths, tray log folder, telemetry fixes - #101
Merged
Conversation
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
This PR updates Pointframe’s logging/telemetry behavior and documentation by centralizing local log paths, adding a tray entry point to open the logs folder, and tightening telemetry so exception details aren’t forwarded.
Changes:
- Centralize log file/folder paths via a new
AppPathshelper and wire Serilog + tray UI to it. - Update telemetry implementation (dispose/flush behavior, privacy changes around exceptions) and heartbeat interval (now 4 hours).
- Refresh README/website privacy messaging and bump app version to 5.9.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| website/free-snagit-alternative-windows.html | Updates marketing copy to reflect anonymous telemetry in official builds. |
| version.json | Bumps version from 5.8 to 5.9. |
| README.md | Expands/clarifies privacy & telemetry documentation, event list, and log location. |
| Pointframe/Services/TrayIconManager.cs | Adds “Open Logs Folder” tray menu item using centralized log path. |
| Pointframe/Services/TelemetryService.cs | Adjusts telemetry lifecycle and prevents forwarding exception objects to the remote logger. |
| Pointframe/Services/TelemetryHeartbeatService.cs | Changes heartbeat interval from 30 minutes to 4 hours. |
| Pointframe/Services/AppPaths.cs | Introduces centralized LocalAppData/log path definitions. |
| Pointframe/App.xaml.cs | Uses AppPaths.RollingLogPath and reorders exit flush relative to host shutdown. |
| Pointframe.Tests/Services/TrayIconManagerTests.cs | Adds test coverage for opening the logs folder from tray. |
| Pointframe.Tests/Services/TelemetryServiceTests.cs | Adds assertion that exception objects aren’t forwarded via telemetry logger calls. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| private void OpenLogsFolder_Click(object sender, RoutedEventArgs e) | ||
| { | ||
| Directory.CreateDirectory(AppPaths.LogsDirectory); | ||
| OpenFolder(AppPaths.LogsDirectory); |
Comment on lines
+284
to
+296
| [Fact] | ||
| public void OpenLogsFolder_Click_OpensLocalLogsFolder() | ||
| { | ||
| StaTestHelper.Run(() => | ||
| { | ||
| var processMock = new Mock<IProcessService>(); | ||
| var manager = CreateManager(processService: processMock.Object); | ||
|
|
||
| InvokePrivate(manager, "OpenLogsFolder_Click", new object(), new RoutedEventArgs()); | ||
|
|
||
| processMock.Verify(process => process.Start(It.Is<ProcessStartInfo>(info => | ||
| info.FileName == "explorer.exe" && info.Arguments == AppPaths.LogsDirectory)), Times.Once); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.