Repository navigation
Add CI quality gates: 95% coverage, lint, format, typecheck, CodeQL - #5
Merged
Merged
Conversation
- test:coverage runs the VS Code tests with coverage and fails below 95% on lines, statements, functions, or branches - Prettier formatting check; ESLint upgraded to strictTypeChecked - tsc --noEmit typecheck and npm audit on runtime dependencies - GitHub Actions CI workflow (xvfb for VS Code tests) and CodeQL workflow - Tests for toggling dictation and deactivate (100% coverage) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TC6WCRgEsuzNtiSyAN59vi
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TC6WCRgEsuzNtiSyAN59vi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI workflow (
.github/workflows/ci.yml), on every PR and push tomain:prettier --check, type-aware ESLint (strictTypeChecked+stylisticTypeChecked),tsc --noEmit, andnpm audit --omit=dev --audit-level=highxvfbwith coverage.scripts/check-coverage.mjsfails the job if lines, statements, functions, or branches are below 95%. The coverage report is uploaded as an artifact..vsix.CodeQL workflow (
.github/workflows/codeql.yml):security-and-qualityqueries on PRs, pushes tomain, and weekly.Other changes
format,format:check,typecheck,test:coverage,check(runs everything CI runs)deactivate. Coverage is now 100%.Notes
@vscode/test-cli(latest) depends on a mocha version with a high-severityserialize-javascriptadvisory. That code runs only in tests and is not shipped in the extension.xvfb, and the VS Code test host downloads itself.main.Test plan
npm run checkpasses locally: 3 tests, 100% coverage🤖 Generated with Claude Code
https://claude.ai/code/session_01TC6WCRgEsuzNtiSyAN59vi