Skip to content

Support Swift 5, Remove Warring. - #60

Open
dongdongpc wants to merge 12 commits into
dillidon:newfrom
dongdongpc:new
Open

Support Swift 5, Remove Warring.#60
dongdongpc wants to merge 12 commits into
dillidon:newfrom
dongdongpc:new

Conversation

@dongdongpc

Copy link
Copy Markdown

No description provided.

@neodave

neodave commented Oct 8, 2018

Copy link
Copy Markdown

I would be very interested in this

@neodave

neodave commented Oct 9, 2018

Copy link
Copy Markdown

The automated 4.2 code update works perfectly except for the UIAlertControllers. dongdongpc has the correct code for that in his fix. This should be simple to do

@tejas-ardeshna

Copy link
Copy Markdown

@dillidon Please merge this PR

Yingdong Wang added 2 commits March 30, 2019 01:25
2.Add Switch "@unknown default:fatalError()"
3.Remove deprecated Method, Support Swift 5
@dongdongpc dongdongpc changed the title Fix error in swift 4.2 Support Swift 5 Mar 29, 2019
@dongdongpc dongdongpc changed the title Support Swift 5 Support Swift 5, Remove Warring. Mar 29, 2019

@shengyang998 shengyang998 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that you need to remove Alerts&Pickers.podspec from project to make it compile successfully.

@furkanvijapura furkanvijapura left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@james-ff

Copy link
Copy Markdown

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants