Fix compile errors: add libp2p dep, re-export PeerSnapshot, remove unused miner variable - #19
Open
dill-lk wants to merge 5 commits into
Open
Fix compile errors: add libp2p dep, re-export PeerSnapshot, remove unused miner variable#19dill-lk wants to merge 5 commits into
dill-lk wants to merge 5 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds the libp2p dependency to the lattice binary, removes an unused current_height variable from the miner implementation, and exports PeerSnapshot from the lattice-rpc crate. I have no feedback to provide as there are no review comments or issues identified.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
latticebinary from compiling by making required symbols available tobins/latticeat build time.PeerSnapshotavailable from thelattice-rpccrate root so downstream consumers can import it aslattice_rpc::PeerSnapshot.-D warningsand failed the build.Description
libp2pdependency to thelatticebinary by updatingbins/lattice/Cargo.tomlsouse libp2p::...imports resolve.PeerSnapshotfromcrates/lattice-rpc/src/lib.rsby changingpub use handlers::{ChainState, RpcHandlers};topub use handlers::{ChainState, PeerSnapshot, RpcHandlers};soPeerSnapshotis available at the crate root.current_heightbinding inbins/lattice/src/miner/mod.rsto eliminate theunused variablecompile error under-D warnings.Testing
cargo check -p latticewhich progressed past the originally reported Rust symbol and unused-variable errors but continued into long-running native dependency compilation (RocksDB and other crates) and was stopped by the environment before completing.cargo check -p lattice-rpcwhich also compiled past the earlier export error and reached heavy native compilation and was stopped for the same environment limitation.Codex Task