REF-11 Fix GitHub issues (#65, #63, #75) - #81
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XFEHBfb5PM63Qi8idztJYG
FederationConfig only deserializes the SigningCertificates collection; a bare <SigningCertificate> element was silently ignored by the XML serializer. Wrap it so the test signing certificate is actually parsed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XFEHBfb5PM63Qi8idztJYG
The SP requested https://data.gov.dk/model/core/eid/fulName, which can never match the fullName attribute NemLog-in actually issues. Fix the name in WebsiteDemo Web.config and the SP metadata. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XFEHBfb5PM63Qi8idztJYG
This was referenced Jul 1, 2026
thomasnymand
changed the title
This was referenced Jul 2, 2026
thomasnymand
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a batch of small, self-contained GitHub issues.
Changes
Net SAML2 Service Provider Framework.docx(Softwarebørsen closed in 2019).SigningCertificateignored.FederationConfigonly deserializes theSigningCertificatescollection; the bare<SigningCertificate>indk.nita.test.saml20/app.configwas silently dropped by the XML serializer. Wrapped it in<SigningCertificates>so it is actually parsed.fulNametypo. The SP requestedhttps://data.gov.dk/model/core/eid/fulName, which never matches thefullNameattribute NemLog-in issues (seetest-devtest4-idp-metadata.xml). Corrected inWebsiteDemo/Web.configand the SP metadatasaml.oiosaml3-net.dk.xml.Testing
Config/metadata/doc changes plus two small guard/validation changes in the config and protocol layers. No cross-platform build path exists (Windows/msbuild only); relying on the CI pipeline. Verified all
ParseFilecallers now null-guard, and that the demo configs' endpoint ids match their metadataentityIDs🤖 Generated with Claude Code