REF-25: Remove stale LBSB examples; convert docs to markdown - #53
Open
thomasnymand wants to merge 1 commit into
Open
REF-25: Remove stale LBSB examples; convert docs to markdown#53thomasnymand wants to merge 1 commit into
thomasnymand wants to merge 1 commit into
Conversation
LBSB (Liberty Basic SOAP Binding) was the first profile this library implemented; OIO IDWS SOAP later superseded it. The LBSB examples are a near-duplicate of oio-idws-soap that only add the retired urn:liberty:sb framework header, point at the decommissioned ADFS STS (sts cert expired 2020), have no integration tests, and have had no real code change since 2021. - Remove examples/lbsb/ and drop the <module>lbsb</module> from examples/pom.xml. Reactor still builds (verified, JDK 8). - Remove docs/traces/lbsb/ (captured LBSB message traces). - Because the docs use the LBSB document as the primary reference and describe OIO IDWS as a delta on it, convert every docx in docs/ to GitHub-flavoured markdown under a new doc/ folder (pandoc), with embedded media extracted per document. The docx originals are retained for now. Known limitation: 3 Word diagrams are EMF and won't render on GitHub; no EMF->PNG/SVG converter was available. Flagged for follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REF-25
Why
LBSB (Liberty Basic SOAP Binding) was the first profile this library implemented; OIO IDWS SOAP superseded it. The
examples/lbsb/tree is a near-duplicate ofexamples/oio-idws-soap/that only adds the retiredurn:liberty:sbframework header. Its shared classes (e.g.DigstSTSClient) are byte-identical to the SOAP ones, it points at the decommissioned ADFS STS (stscert expired 2020), it has no integration tests, and no real code change since 2021.Changes
examples/lbsb/(5 modules) and drop<module>lbsb</module>fromexamples/pom.xml. Reactor still builds — verified withmvn clean install -DskipTestson JDK 8 (20 modules, BUILD SUCCESS).docs/traces/lbsb/(captured LBSB message traces)..docxindocs/is converted to GitHub-flavoured markdown under a newdoc/folder (pandoc), with embedded media extracted per document. The.docxoriginals are retained for now.doc/)nemlog-in2-lbsb-scenarios.mdnemlog-in2-oio-idws-1.1-scenarios.mdnemlog-in2-oio-idws-rest-scenarios.mdhealthcare-oio-idws-xua-scenarios.mdcxf-and-ws-securitypolicy.mdKnown limitation
3 Word diagrams are EMF and won't render on GitHub (no EMF→PNG/SVG converter was available on the build host). Flagged as a follow-up — they can be re-exported as PNG/SVG later.
Notes
netcross-stack examples and all OIO IDWS SOAP/REST scenarios are unaffected.