Reorganize to top-level src/ layout; remove unused installer config#35
Conversation
Polymer plugins are discovered by package type and installed to vendor by default, so the custom installer-name and the custom-directory-installer / installers-extender allow-plugins entries are no longer needed. Refs PWT-115. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request reorganizes the codebase by updating namespaces to DigitalPolygon\Polymer\polymer_pantheon_drupal, updating dependencies in composer.json, and introducing GrumPHP configurations along with git hooks and PHP CodeSniffer rulesets. Feedback on these changes highlights three key issues: the PSR-4 autoloading configuration for the new namespace was accidentally removed from composer.json and must be restored, and the git hooks (pre-commit and commit-msg) unconditionally prefix commands with ddev exec -- when IS_DDEV_PROJECT is empty, which will break commits for non-DDEV users and should instead check for DDEV's availability.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Only prefix git hook commands with `ddev exec --` when not in a DDEV container AND a .ddev directory and the ddev binary are present, so commits do not break for non-DDEV developers. Refs PWT-115. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1 participant
Summary
Reorganizes the polymer-pantheon-drupal extension to a top-level
src/layout, splits the coding-standards config (PSR-12 vs Drupal) with a GrumPHP pre-commit hook, and removes installer configuration that is no longer needed.Refs PWT-113, PWT-115.
What's in here
4cded5b,785b4c4): move classes fromsrc/Polymer/...tosrc/...; splitphpcs.xml.distintophpcs-non-drupal.xml.dist(PSR-12) andphpcs-drupal.xml.dist; add a GrumPHP pre-commit hook; coding-standards fixes across commands, hooks, templates, and event subscribers.b856fec): dropextra.installer-nameand themnsami/composer-custom-directory-installer/oomphinc/composer-installers-extenderallow-pluginsentries. Polymer core discovers plugins by package type and installs them tovendor/by default, so no installer machinery is needed. (oomphinc/composer-installers-extenderwas archived upstream.)🤖 Generated with Claude Code