Reorganize to top-level src/ layout; remove unused installer config#28
Conversation
Polymer plugins are discovered by package type and installed to vendor by default, so the custom installer-name and the custom-directory-installer / installers-extender allow-plugins entries are no longer needed. Refs PWT-115. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request reorganizes the project's namespace from DigitalPolygon\PolymerDrupal to DigitalPolygon\Polymer\polymer_drupal, updates dependencies, and refactors configuration and settings files to support the new structure. While these changes align the project with the updated organization, several critical issues need to be addressed. Specifically, the PSR-4 autoloading mapping for the new namespace was omitted in composer.json, which will cause runtime class-not-found errors. Additionally, a logic change in settings/db.settings.php causes default DDEV database settings to unconditionally overwrite custom configurations. Other issues include outdated namespace references in SetupCommands.php, incorrect PHPStan constructor paths, and minor indentation inconsistencies in the settings files that violate coding standards.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
- db.settings.php: only apply the default DDEV database config when settings.ddev.php was not loaded (it was unconditionally overwriting DDEV/multisite settings). - SetupCommands: emit the new \\DigitalPolygon\\Polymer\\polymer_drupal\\VendorAssets namespace into generated settings (the old \\DigitalPolygon\\PolymerDrupal reference no longer exists). - phpstan.neon: point additionalConstructors at the polymer_drupal event classes instead of the Core namespace. - settings templates: fix require/phpcs:ignore indentation for the Drupal coding standard. Refs PWT-115. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…branch The reorganization landed on polymer 0.x (PR #76) and the feature/refactor-organization branch was deleted, so the dev-feature/refactor-organization constraint no longer resolves and CI composer install fails. Point at 0.x-dev. Refs PWT-115. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The reorg split phpcs.xml.dist into phpcs-non-drupal.xml.dist (PSR-12, src) and phpcs-drupal.xml.dist (Drupal, settings), but the composer cs script still ran bare `phpcs`, which finds no config and errors with "You must supply at least one file or directory". Point it at both standards. Refs PWT-115. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1 participant
Summary
Reorganizes the polymer-drupal extension to a top-level
src/layout (moving classes out of thesrc/Polymer/subdirectory), applies coding-standards fixes, and removes installer configuration that is no longer needed.Refs PWT-113, PWT-115.
What's in here
cff98e9,7f09605,6bc7844): move plugin classes fromsrc/Polymer/...tosrc/..., with coding-standards and code fixes across commands, hooks, tasks, the service provider, and event subscribers.bf39c65): dropextra.installer-nameand themnsami/composer-custom-directory-installer/oomphinc/composer-installers-extenderallow-pluginsentries. Polymer core now discovers plugins by package type and installs them tovendor/by default, so this package needs no installer machinery. (oomphinc/composer-installers-extenderwas also archived upstream.)🤖 Generated with Claude Code