This repository was archived by the owner on Jun 17, 2026. It is now read-only.
Add method to unregister metrics - #63
Open
a-rose wants to merge 3 commits into
Open
Conversation
Ayrdim
pushed a commit
to Omnitouch/prometheus-client-c
that referenced
this pull request
May 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This PR adds
prom_collector_registry_unregister_metric(). This gives the ability to remove metrics without having to restart the whole registry.It also contains a fix for a crash in
prom_map_delete_internalwhere the node is deleted before its key, resulting in using a deleted object when deleting the key later on.