Add amd-smi to docker image - #38
Merged
Merged
Conversation
d-honeybadger
approved these changes
Aug 28, 2026
d-honeybadger
left a comment
d-honeybadger
left a comment
Contributor
There was a problem hiding this comment.
I wonder about amdsmi compatibility with amdgpu: different clusters/workers may have different amdgpu version so that a single doks-debug image isn't compatible with all. And if maybe having a script to install amdsmi of proper version in the doks-debug container would work better than baking in amd-smi at a specific version in the image.
We can see how this plays out though and change later
|
Good point re versioning @d-honeybadger, I hope it'd work across versions, but better to see if we can find info on that or test it out. |
Contributor
Author
|
Tested on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ROCm 7.14 standalone amd-smi (amdrocm-amdsmi) to the doks-debug image for AMD GPU node debugging
Document it in the README (container shell on AMD GPU nodes)