Skip to content

2772: Add test for import pois from csv - #4534

Merged
bahaaTuffaha merged 1 commit into
developfrom
2772-Add-tests-for-csv-import-of-POIs
Sep 1, 2026
Merged

2772: Add test for import pois from csv#4534
bahaaTuffaha merged 1 commit into
developfrom
2772-Add-tests-for-csv-import-of-POIs

Conversation

@bahaaTuffaha

Copy link
Copy Markdown
Contributor

Short description

When implementing #2768, we didn't add a test for this command.

Proposed changes

  • Created a new test test_import_pois_from_csv.py.
  • Used get_command_output and asserted CommandError for missing args.
  • Covered a missing-arguments call, unknown region/user, successful import, address and flag mapping, categories, opening hours, and a row failing form validation.
  • Updated phone numbers in pois_to_import.csv to +49 format so they pass POIForm validation.

Side effects

  • none.

Faithfulness to issue description and design

There are no intended deviations from the issue and design.

How to test

  • Run tests (./tools/test.sh)

Resolved issues

Fixes: #2772


Pull Request Review Guidelines

@bahaaTuffaha bahaaTuffaha changed the title 2772: Added test for import pois from csv 2772: Add test for import pois from csv Aug 24, 2026
@connium connium added the prio: low Not urgent, can be resolved in the distant future. label Aug 26, 2026

@MizukiTemma MizukiTemma left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much 😸 Those test will definetely support us!

@MizukiTemma MizukiTemma self-assigned this Aug 27, 2026

@seluianova seluianova left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@bahaaTuffaha
bahaaTuffaha force-pushed the 2772-Add-tests-for-csv-import-of-POIs branch from 9244802 to 3be3da3 Compare September 1, 2026 17:54
@bahaaTuffaha
bahaaTuffaha merged commit 72604df into develop Sep 1, 2026
5 checks passed
@bahaaTuffaha
bahaaTuffaha deleted the 2772-Add-tests-for-csv-import-of-POIs branch September 1, 2026 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

prio: low Not urgent, can be resolved in the distant future.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests missing for CSV import of POIs

4 participants