3726: Fix the tooltip of the restore contact button - #4530
Open
hdimer wants to merge 1 commit into
Open
Conversation
The restore button on the contact form had title="Restore page", copied from the page sidebar. Use "Restore contact", the string the contact list row already uses for the same action. Fixes: digitalfabrik#3726
MizukiTemma
approved these changes
Aug 27, 2026
MizukiTemma
left a comment
MizukiTemma
left a comment
Member
There was a problem hiding this comment.
Fixed 😸 Thank you for your contribution in our repository 🎉
Author
|
Thanks for the quick review. Glad it was useful, happy to pick up more from the tracker if there's anything open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
The restore button on an archived contact's detail/edit form shows the tooltip "Restore page" instead of "Restore contact". The
titleattribute was copy-pasted from the page sidebar; this changes it to the string the contact list row already uses.Proposed changes
contacts/contact_form.html:title="{% translate "Restore page" %}"→title="{% translate "Restore contact" %}".contacts/contact_list_row.htmlalready uses"Restore contact"for the same action, so no new msgid is introduced.locale/de/LC_MESSAGES/django.powith./tools/translate.sh(only the source-file comments of the two existing entries move).titleattribute for restore contact button #3726.I left the button's visible label as "Restore this contact". That mirrors the other form sidebars, which all pair
title="Restore <entity>"with the label "Restore this " (pages, POIs), so the forms stay consistent.No test: there are no assertions on template copy or
titleattributes anywhere intests/, and the nearest comparable change (b4ff5af, the Push Notification -> News rename) added none either. Happy to add one if you'd rather have it pinned.Small thing I noticed but did not touch: in German both msgids render as "Kontakt wiederherstellen", so the tooltip and the button label now read identically. Pages avoids that with "Seite wiederherstellen" / "Diese Seite wiederherstellen". That is a wording call on the other msgid, so I left it out of this PR.
Side effects
"Restore page"is still used bypages/page_form_sidebar/actions_box.htmlandpages/pages_page_tree_node.html, so the msgid stays in the translation file.Faithfulness to issue description and design
There are no intended deviations from the issue and design.
How to test
Archive a contact, open it, scroll to the restore button and hover it. The tooltip should read "Restore contact" / "Kontakt wiederherstellen".
Resolved issues
Fixes: #3726
Pull Request Review Guidelines
Used AI assistance on this; I reviewed and tested the change myself.