[Link Checker GUI] Improve link source column - #4516
Merged
MizukiTemma merged 1 commit intoAug 27, 2026
Merged
Conversation
MizukiTemma
force-pushed
the
linkchecker_gui/source_page_column
branch
from
August 13, 2026 14:23
8d90a7b to
a886c88
Compare
5 tasks
|
@MizukiTemma Things I found while checking the design (not sure some of it will be implemented in another issue):
|
Member
Author
|
Thank you for review 😸
|
seluianova
reviewed
Aug 24, 2026
seluianova
approved these changes
Aug 24, 2026
seluianova
left a comment
Contributor
There was a problem hiding this comment.
nice design and nice implementation 👍
seluianova
reviewed
Aug 24, 2026
seluianova
reviewed
Aug 24, 2026
hannaseithe
self-requested a review
August 25, 2026 10:12
hannaseithe
requested changes
Aug 25, 2026
hannaseithe
left a comment
Contributor
There was a problem hiding this comment.
Thank you very much for working on this issue! I have a few change requests below
MizukiTemma
force-pushed
the
linkchecker_gui/source_page_column
branch
from
August 25, 2026 15:56
d7f79c0 to
339f987
Compare
Member
Author
|
Thank you for review 😸 The PR is updated according to your suggestions ✏️ |
hannaseithe
approved these changes
Aug 26, 2026
hannaseithe
left a comment
Contributor
There was a problem hiding this comment.
Thank you very much for working in my change requests. This looks good to me :)
MizukiTemma
changed the base branch from
develop
to
stories/make_link_checker_gui_more_intuitive_2837
August 26, 2026 10:22
MizukiTemma
force-pushed
the
linkchecker_gui/source_page_column
branch
from
August 26, 2026 13:11
41e8aa5 to
03fa6ee
Compare
MizukiTemma
force-pushed
the
linkchecker_gui/source_page_column
branch
from
August 27, 2026 08:21
03fa6ee to
3e59224
Compare
MizukiTemma
merged commit Aug 27, 2026
e3fa396
into
stories/make_link_checker_gui_more_intuitive_2837
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Short description
This PR introduced the new design for the column "Where is the link/Wo steht der link" (old: Quelle) as suggsted in the design.
Proposed changes
show_source_linkas it won't link to the content form anymoreobject_translation_has_view_permwhich was only used forshow_source_linkSide effects
Faithfulness to issue description and design
Changes for cases that are not specifically mentioned:
default_languagereturnsNoneHow to test
Resolved issues
Fixes: #4459
Pull Request Review Guidelines