Bugfix: Update translation state to machine_translated when an outdated translation is machine translated without changes - #4399
Merged
seluianova merged 1 commit intoAug 31, 2026
Conversation
seluianova
force-pushed
the
4320-translation-status-is-not-updated-when-source-and-target-translations-are-empty
branch
5 times, most recently
from
July 1, 2026 10:47
603abd0 to
721a665
Compare
seluianova
force-pushed
the
4320-translation-status-is-not-updated-when-source-and-target-translations-are-empty
branch
from
August 19, 2026 08:50
c98ab93 to
0d955d3
Compare
seluianova
changed the title
seluianova
force-pushed
the
4320-translation-status-is-not-updated-when-source-and-target-translations-are-empty
branch
from
August 19, 2026 09:06
0d955d3 to
464a6b0
Compare
seluianova
marked this pull request as ready for review
August 19, 2026 09:10
seluianova
force-pushed
the
4320-translation-status-is-not-updated-when-source-and-target-translations-are-empty
branch
2 times, most recently
from
August 19, 2026 10:10
fb97adc to
a13a4d9
Compare
MizukiTemma
self-requested a review
August 25, 2026 12:53
MizukiTemma
approved these changes
Aug 25, 2026
MizukiTemma
left a comment
MizukiTemma
left a comment
Member
There was a problem hiding this comment.
Looks good 😸 Nice with a new test added 👍
hannaseithe
requested review from
hannaseithe
and removed request for
hannaseithe
August 26, 2026 09:54
PeterNerlich
approved these changes
Aug 28, 2026
PeterNerlich
left a comment
PeterNerlich
left a comment
Contributor
There was a problem hiding this comment.
Thank you! I have two nitpicks, neither of which keep this from being merged as-is, if need be.
seluianova
force-pushed
the
4320-translation-status-is-not-updated-when-source-and-target-translations-are-empty
branch
from
August 31, 2026 10:43
a13a4d9 to
e6dc491
Compare
…lation is machine translated without changes
seluianova
force-pushed
the
4320-translation-status-is-not-updated-when-source-and-target-translations-are-empty
branch
from
August 31, 2026 11:05
e6dc491 to
a174380
Compare
seluianova
deleted the
4320-translation-status-is-not-updated-when-source-and-target-translations-are-empty
branch
August 31, 2026 11:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
This PR fixes the following issue:
It was not possible to machine-translate the page to English because of the following error:
Page "Translation test" was not translated into 'English' because there were no changes to the source translation.Proposed changes
refreshed_translationsflow in theMachineTranslationApiClientclass for outdated pages with no changes.Side effects
hopefully none
Faithfulness to issue description and design
There are no intended deviations from the issue and design.
How to test
Follow the steps in the bug description.
Resolved issues
Fixes: #4320
Pull Request Review Guidelines