Skip to content

Preparations for async multi connection#295

Open
jusax23 wants to merge 5 commits into
diesel-rs:mainfrom
jusax23:dev-async_multi_connection
Open

Preparations for async multi connection#295
jusax23 wants to merge 5 commits into
diesel-rs:mainfrom
jusax23:dev-async_multi_connection

Conversation

@jusax23

@jusax23 jusax23 commented Jun 26, 2026

Copy link
Copy Markdown

This PR makes changes needed for an AsyncMultiConnection:

  • adds AsyncMultiConnectionHelper
    • implemented for AsyncMysqlConnection
    • implemented for PgAsyncMetadataLookup
    • implemented for SyncConnectionWrapper
  • changes of lifetimes of SyncConnectionWrapper

prior discussion: #108

@weiznich weiznich left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR. The changes look good to me, although I would like to wait with merging them until the second part (changes to the derive) is also done.

@jusax23

jusax23 commented Jul 7, 2026

Copy link
Copy Markdown
Author

Hi, I've pushed a new commit to this to pr, to add expand_pool. I've added this to lib.rs, I hope thats okay.

@weiznich

Copy link
Copy Markdown
Member

That's fine

This still needs to include an adjusted copy of https://github.com/diesel-rs/diesel/blob/main/diesel_derives/src/multiconnection.rs to demonstrate that the derive works

@BlackDex

Copy link
Copy Markdown

This PR might be useful for Vaultwarden to get rid of the MySQL/MariaDB issues.
Not sure what kind of other impact it might have regarding secure connections or specific authentication protocols though.

@jusax23

jusax23 commented Jul 18, 2026

Copy link
Copy Markdown
Author

Hi @weiznich , I've pushed a modified version of the sync test. It runs sucessful on my machine, when i change the diesel dependency to a local copy of main. So this pr can only be merged after a supported diesel version is released, or with the added module in tests/lib.rs commented out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants