Correctly check if a connection returned to a mobc pool is still usable#290
Merged
Conversation
This commit adds an additional check to the mobc manager implementation to check if the connection is still valid if it's returned to the pool. This checks for open transactions and if we are currently panicing. This check mirrors the checks we do for the other pool implementations as well. For some reason it was missing for mobc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds an additional check to the mobc manager implementation to check if the connection is still valid if it's returned to the pool. This checks for open transactions and if we are currently panicing. This check mirrors the checks we do for the other pool implementations as well. For some reason it was missing for mobc.