fix(settings): default debugMode to false - #10308
Conversation
getSettings() used debugMode: true as the overlay default, so any install without a persisted key ran with debug logging. The Advanced toggle is documented as opt-in.
|
Implements / pairs with #10312. |
|
Thanks for the PR and for the detailed writeup in #10312 — I dug into this before merging and wanted to share what I found. I traced every consumer of The If you're seeing real debug-level log noise on a clean install, I'd genuinely like to track that down — but it isn't coming from this flag, so a fresh issue with a concrete log excerpt/repro would help a lot more than adjusting this default. Given that, I don't think this should merge as-is, and I'll be flagging it to the maintainer as such — but happy to look at a follow-up once we've got the actual log-source pinned down, or at a small docs fix for the CONTRIBUTING.md wording if you'd like to send that instead. Appreciate you digging in and reporting it either way. |
Adds an automated test covering the getSettings() debugMode default so the production-code change ships with a regression guard per repo test policy. Co-authored-by: diegosouzapw <diegosouza.pw@gmail.com>
Babysit summary
|
|
Hi @RaviTharuma — thanks for this. This fix is already covered byte-for-byte by #10372 ( |
Summary
getSettings()seedsdebugMode: truebefore overlaying sqlite. A missing key means production debug logging is on.false. Persistedtrueis unchanged.Validation
debugMode: truestill apply.Reviewer Notes
No secrets. Behavior change only for installs that never persisted the key.