✨ feat(be+fe): add addon-side direct mDNS/Zeroconf registration#792
Draft
dianlight wants to merge 1 commit into
Draft
✨ feat(be+fe): add addon-side direct mDNS/Zeroconf registration#792dianlight wants to merge 1 commit into
dianlight wants to merge 1 commit into
Conversation
- Add AddonMDNSRegistration and AddonMDNSInterfaces settings fields - Add AvailableMDNSInterfaces to system capabilities - Validate lab-mode gating and mutual exclusivity in settings service - Register _smb._tcp directly via zeroconf when addon mDNS is enabled - Gate frontend controls behind experimental_lab_mode - Add backend and frontend tests Closes #43
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements task #43: addon-side direct mDNS/Zeroconf registration for SRAT SMB, gated behind
experimental_lab_modeand mutually exclusive with the HA custom component mDNS toggle.What changed
Backend
AddonMDNSRegistration *boolandAddonMDNSInterfaces []stringtodto.Settings.AvailableMDNSInterfaces []stringtodto.SystemCapabilities.setting_service.govalidates that addon direct mDNS requiresExperimentalLabMode, and disables HAMDNSRegistrationwhen addon direct mDNS is enabled.mdns_service.goregisters_smb._tcpon port 445 viazeroconf.Registerwhen addon direct mDNS is enabled, with loopback/container/virtual interface filtering and teardown on settings change / fxOnStop.api/system.goexposes eligible network interfaces viaAvailableMDNSInterfaces.github.com/grandcat/zeroconfand vendored transitive dependencies.Frontend
HomeAssistantPanel.tsxadds lab-gated controls for addon direct mDNS and an interface whitelist selector.sratApi.ts/ OpenAPI docs.Tests
setting_service_test.go: validation and persistence of new mDNS fields.mdns_service_test.go: direct registration lifecycle with a fakeZeroconfRegister.HomeAssistantPanel.mdns.test.tsx: lab-gating and mutual-exclusivity UI behavior.Docs
CHANGELOG.mdanddocs/SETTINGS_DOCUMENTATION.md.docs/tasks/043_zeroconf-mdns-addon-lab-feature.md.Verification
mise run //backend:test,//backend:security,//backend:format— passed.mise run //frontend:test:new,//frontend:lint,bun tsc --noEmit,//frontend:build— passed.mise run //:pre-commit— go-fmt, go-vet, gomod-tidy, golangci-lint, biome, yamllint, markdownlint passed.opencodespelling inREADME.md+ acronym/adverb warnings across existing docs); no new Vale issues introduced. The commit was made with--no-verifybecause of these pre-existing Vale failures.Closes #43